Skip to content

Conversation

@0Ayachi0
Copy link

@0Ayachi0 0Ayachi0 commented Jan 25, 2026

Motivation

功能模块 fastdeploy/inter_communicator/zmq_server.py 单测补充
image
develop分支,覆盖率23 ,miss行数231(54-55, 69-85, 91-111, 117-129, 135-146, 152-160, 166-177, 183-194, 198-225, 231-257, 263-314, 317-320, 327, 342->344, 366->exit, 369-370, 377, 382->384, 384->386, 387-389, 398-410, 414-419, 425-434, 440-452, 458-471)
e43d0567e115e820bdc15e266c541740
当前pr,覆盖率91,miss行数19

完成单测覆盖行数231-19=212

Modifications

add unittest tests\inter_communicator\test_zmq_server.py

Usage or Command

No need

Accuracy Tests

No need

Checklist

  • Add at least a tag in the PR title.
    • Tag list: [[FDConfig],[APIServer],[Engine], [Scheduler], [PD Disaggregation], [Executor], [Graph Optimization], [Speculative Decoding], [RL], [Models], [Quantization], [Loader], [OP], [KVCache], [DataProcessor], [BugFix], [Docs], [CI], [Optimization], [Feature], [Benchmark], [Others], [XPU], [HPU], [GCU], [DCU], [Iluvatar], [Metax]]
    • You can add new tags based on the PR content, but the semantics must be clear.
  • Format your code, run pre-commit before commit.
  • Add unit tests. Please write the reason in this PR if no unit tests.
  • Provide accuracy results.
  • If the current PR is submitting to the release branch, make sure the PR has been submitted to the develop branch, then cherry-pick it to the release branch with the [Cherry-Pick] PR tag.

@paddle-bot
Copy link

paddle-bot bot commented Jan 25, 2026

Thanks for your contribution!

@paddle-bot paddle-bot bot added the contributor External developers label Jan 25, 2026
@0Ayachi0
Copy link
Author

@luotao1 涛姐,帮我approval下

@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (develop@253c5cc). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #6210   +/-   ##
==========================================
  Coverage           ?   66.68%           
==========================================
  Files              ?      383           
  Lines              ?    50624           
  Branches           ?     7905           
==========================================
  Hits               ?    33761           
  Misses             ?    14398           
  Partials           ?     2465           
Flag Coverage Δ
GPU 66.68% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants