-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
nix: add script and ci workflow to enforce changelog entries #4596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
nix: add script and ci workflow to enforce changelog entries #4596
Conversation
Signed-off-by: Taimoor Zaeem <[email protected]>
|
Years ago I worked a bit on #1805, but this never really lead anywhere. I believe if we want any kind of checks for changelog (or improve the process to maybe only have a single source of truth or whatever), then we need to store the changelog in a structured way, not in the freetext format we have right now. I am skeptical of trying to read the current changelog and have any checks on it. (I did not actually look much at the code itself, only very briefly skimmed it) |
Agree with the structured format. I also skimmed at the PR code before and looked like the check could fail in certain ways. |
|
I like the idea of a structured format as well. Just like in #1805, maybe we can have a format like: changelog:
- version: 14.0
date: 2025-11-05
added:
- description: Bounded JWT cache using the SIEVE algorithm
details:
- It now uses a fixed size cache instead of arbitrary sized cache.
author: mkleczek
refs: [4084]
fixed:
- description: Fix not logging OpenAPI queries when `log-query=main-query` is enabled
author: steve-chavez
refs: [4226]
- description: Fix not logging explain query when `log-query=main-query` is enabled
author: steve-chavez
refs: [4319]
changed:
- description: Drop support for PostgreSQL EOL version 12
author: wolfgangwalther
refs: [4319] |
A few high-level thoughts after having done similar things in the past:
|
I don't think that would work given given old releases didn't use the commit prefixes?
Sounds interesting, which tool does that? 👀 |
You can always append the existing changelog to the newly generated part.
There are probably multiple, I can't remember which tool I saw this first on. A google search brings up https://github.com/churchtools/changelogger. |
@wolfgangwalther What you are describing seems very similar to https://github.com/twisted/towncrier, is this the one? |
|
The name sounds familiar, could be it, not 100% sure. |
Closes #4590.
I would love some feedback on this.