add: Self links #4601
Draft
add: Self links #4601
+168
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkleczek
force-pushed
the
selflinks
branch
4 times, most recently
from
59fde2e to
e115bb3
Compare
Comment on lines
+278
to
+290
| let -- Build an array of "key=eq.value" parts for non-null PK columns using direct column refs. | ||
| buildPart col = | ||
| SQL.sql (encodeUtf8 $ pgFmtLit (col <> "=eq.")) <> " || (" <> (fromQi table <> "." <> pgFmtIdent col) <> "::text)" | ||
| partsArr = "array_remove(ARRAY[" <> intercalateSnippet ", " (buildPart <$> pkCols) <> "], NULL)" | ||
| -- Use the base table name for the path (strip trailing _N aliases like clients_1 -> clients) | ||
| tblName = qiName table | ||
| parts = T.splitOn "_" tblName | ||
| baseName = case reverse parts of | ||
| (s:rest) | T.all isDigit s && not (null rest) -> T.intercalate "_" (reverse rest) | ||
| _ -> tblName | ||
| urlExpr = "CASE WHEN array_length(" <> partsArr <> ",1) = 0 THEN NULL ELSE " <> | ||
| SQL.sql (encodeUtf8 $ pgFmtLit ("/" <> baseName)) <> | ||
| " || '?' || array_to_string(" <> partsArr <> ", '&') END" |
Member
There was a problem hiding this comment.
I believe we already have logic elsewhere to create Location headers, which should result in very similar URIs. We should probaly re-use the same URI generator for both?
Member
There was a problem hiding this comment.
I think we should clarify how would this feature be useful (ref) before going to the implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4236