feat(match): always collapse legs in sub_matchings route results #7211
+13
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR seems to be stale. Is it still relevant? |
…chings-route-results
Author
|
Yes this is still relevant and pending |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Hi, I'm proposing an evolution in the match API, I've open an issue for the occasion :
Legs are not collapsed in /match if no waypoints are provided
Do you think this is a good approach? I need both multiple matchings and leg collapsing to work, but they don't seem to be compatible because of the waypoints parameter. I can’t set waypoints, since I want to retrieve multiple sub-matchings. However, without it, I can't get the legs to collapse properly. I felt stuck, so I ended up with this workaround
Tasklist
Requirements / Relations