-
Notifications
You must be signed in to change notification settings - Fork 13k
docs: add high-level architecture overview #38394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add high-level architecture overview #38394
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
WalkthroughAdds a new repository architecture overview document and a small API/schema change with tests and a changeset: introduces Changes
Sequence Diagram(s)(No sequence diagrams generated — changes are documentation and a small schema/test update that do not introduce new multi-component control flow.) Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Closes RocketChat#38393 - Add system architecture diagram (Mermaid) - Add enterprise microservices diagram - Add data flow diagram for real-time messaging - Add production deployment architecture - Include monorepo structure mapping - Document technology stack and core modules
15ef893 to
7e3e25c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 1 file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@overview.md`:
- Around line 199-206: Update the product name capitalization in the Providers
module list: replace the module label "github" with the correctly capitalized
"GitHub" in the Providers table entry so the product name matches official
casing; locate the "Providers" row containing "apple, github, gitlab,
google-oauth, ldap" and change only "github" to "GitHub".
🧹 Nitpick comments (1)
overview.md (1)
1-1: Consider aligning the title with the document's purpose.The PR objectives describe this as an "architecture overview" for contributors, but the title says "Architecture Report." Consider using "Architecture Overview" for better alignment with the stated purpose.
📝 Suggested title adjustment
-# Rocket.Chat Architecture Report +# Rocket.Chat Architecture Overview
overview.md
Outdated
| ## Core Feature Modules (`apps/meteor/app/`) | ||
|
|
||
| | Category | Modules | | ||
| |----------|---------| | ||
| | **Communication** | livechat, threads, reactions, mentions, e2e | | ||
| | **Auth** | 2fa, authentication, authorization, meteor-accounts-saml, custom-oauth | | ||
| | **Integrations** | apps, integrations, slackbridge, irc, importer-slack | | ||
| | **Providers** | apple, github, gitlab, google-oauth, ldap | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix product name capitalization.
Line 206: "github" should be "GitHub" to match the official product name.
✏️ Proposed fix
-| **Providers** | apple, github, gitlab, google-oauth, ldap |
+| **Providers** | apple, GitHub, gitlab, google-oauth, ldap |📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| ## Core Feature Modules (`apps/meteor/app/`) | |
| | Category | Modules | | |
| |----------|---------| | |
| | **Communication** | livechat, threads, reactions, mentions, e2e | | |
| | **Auth** | 2fa, authentication, authorization, meteor-accounts-saml, custom-oauth | | |
| | **Integrations** | apps, integrations, slackbridge, irc, importer-slack | | |
| | **Providers** | apple, github, gitlab, google-oauth, ldap | | |
| ## Core Feature Modules (`apps/meteor/app/`) | |
| | Category | Modules | | |
| |----------|---------| | |
| | **Communication** | livechat, threads, reactions, mentions, e2e | | |
| | **Auth** | 2fa, authentication, authorization, meteor-accounts-saml, custom-oauth | | |
| | **Integrations** | apps, integrations, slackbridge, irc, importer-slack | | |
| | **Providers** | apple, GitHub, gitlab, google-oauth, ldap | |
🧰 Tools
🪛 LanguageTool
[uncategorized] ~206-~206: The official name of this software platform is spelled with a capital “H”.
Context: ...porter-slack | | Providers | apple, github, gitlab, google-oauth, ldap | --- ## ...
(GITHUB)
🤖 Prompt for AI Agents
In `@overview.md` around lines 199 - 206, Update the product name capitalization
in the Providers module list: replace the module label "github" with the
correctly capitalized "GitHub" in the Providers table entry so the product name
matches official casing; locate the "Providers" row containing "apple, github,
gitlab, google-oauth, ldap" and change only "github" to "GitHub".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@overview.md`:
- Line 3: Update the Technology Stack entry in overview.md so the Node version
matches package.json: change the string containing "**Version:** 8.1.0-develop |
**Node:** 22.16.0 | **Yarn:** 4.12.0" to use Node 22.16.5 (e.g., "**Node:**
22.16.5") so documentation aligns with the ~22.16.5 constraint specified in
package.json.
🧹 Nitpick comments (1)
overview.md (1)
75-78: Consider dropping exact module/package counts to reduce churn.
These counts will age quickly; removing them (or making them approximate) keeps the overview stable.♻️ Proposed tweak
-│ ├── meteor/ # Core server (97 feature modules) +│ ├── meteor/ # Core server (feature modules) -├── packages/ # 55 shared packages +├── packages/ # shared packages
|
Not needed, same as #38401 (comment) |
Summary
Adds a contributor-focused architecture overview document with Mermaid diagrams.
Closes #38393
Changes
Content Overview
Notes for Reviewers
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.