ssh-key: Fix KeyData::Certificate encoding
#451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KeyData was duplicating the algorithm string when encoding a certificate public key to its binary representation. It was also filling in the non-certificate variant of the Algorithm string. This fixes both. Signed-off-by: Ross Williams <[email protected]>
Signed-off-by: Ross Williams <[email protected]>
Signed-off-by: Ross Williams <[email protected]>
overhacked
changed the title
KeyData::Certificate encoding
tarcieri
approved these changes
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KeyDatawas duplicating the algorithm string when encoding a certificate public key to its binary representation. It was also filling in the non-certificate variant of the Algorithm string. This fixes both.@tarcieri, apologies for the quick follow-up PR. I didn't get to test
KeyData'sEncodeimplementation until I used the new pre-release inssh-agent-muxand realized that the algorithm was being emitted twice for certificates. This PR includes integration tests for this.