feat: Prompt for credentials when not available in VSCode for adp generator #4052
Conversation
IvoSG
added
feature
🦋 Changeset detectedLatest commit: 1fa049e The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| "usernameTooltip": "Enter the user name for the back-end system.", | ||
| "passwordLabel": "Password", | ||
| "passwordTooltip": "Enter the password for the back-end system.", | ||
| "storeCredentialsLabel": "Do you want to store the system credentials?", |
There was a problem hiding this comment.
| "storeCredentialsLabel": "Do you want to store the system credentials?", | |
| "storeCredentialsLabel": "Store Credentials", |
There was a problem hiding this comment.
This "Do you want to store the system credentials?" should probably be moved to the tooltip instead
There was a problem hiding this comment.
The question is phrased this way in the Fiori generator, and keeping it is best for consistency.
There was a problem hiding this comment.
I agree with @nikmace's proposal.
We've been moving these more descriptive texts to tooltips and using a more straightforward label text in line with other labels.
There was a problem hiding this comment.
@lfindlaysap Hmm, in the screenshot the Fiori generator has the full question as message for yes / no prompt. I think we should make it the same as in the screenshot to be consistent with Fiori generator.
There was a problem hiding this comment.
@nikmace, I'll make a PR to fix this for the Fiori generator.
nikmace
left a comment
nikmace
left a comment
There was a problem hiding this comment.
Left some comments; the changes look good initially.
| "usernameTooltip": "Enter the user name for the back-end system.", | ||
| "passwordLabel": "Password", | ||
| "passwordTooltip": "Enter the password for the back-end system.", | ||
| "storeCredentialsLabel": "Do you want to store the system credentials?", |
There was a problem hiding this comment.
I agree with @nikmace's proposal.
We've been moving these more descriptive texts to tooltips and using a more straightforward label text in line with other labels.
… changeset descr update
|
nikmace
left a comment
nikmace
left a comment
There was a problem hiding this comment.
Changes look good
Changeset is OK
Coverage is OK
Did not test manually
lfindlaysap
left a comment
lfindlaysap
left a comment
There was a problem hiding this comment.
Replied to open comment.
Feat for #4051