Skip to content

Conversation

@alexey-tikhonov
Copy link
Member

to not even try setting hard limit as SSSD never has CAP_SYS_RESOURCE

to not even try setting hard limit as SSSD never has CAP_SYS_RESOURCE
@alexey-tikhonov alexey-tikhonov added the no-backport This should go to target branch only. label Jan 16, 2026
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors responder_set_fd_limit() to avoid attempting to set the hard limit for file descriptors, as SSSD responders typically lack the necessary CAP_SYS_RESOURCE capability. The change correctly removes the initial setrlimit() call that was likely to fail or behave incorrectly, and instead directly queries the current hard limit to safely adjust the soft limit. The corresponding documentation in sssd.conf.5.xml has been updated to reflect this behavior, and a helpful debug message has been added for cases where the requested limit exceeds the hard limit. The changes are correct, improve efficiency by removing an unnecessary system call, and make the code's intent clearer. I have no further suggestions.

@alexey-tikhonov alexey-tikhonov added non-privileged backport-to-sssd-2-12 and removed no-backport This should go to target branch only. labels Jan 16, 2026
@alexey-tikhonov alexey-tikhonov marked this pull request as ready for review January 16, 2026 17:46
@alexey-tikhonov alexey-tikhonov added Waiting for review coverity Trigger a coverity scan labels Jan 16, 2026
@alexey-tikhonov
Copy link
Member Author

Note: Covscan is green.

@alexey-tikhonov alexey-tikhonov removed the coverity Trigger a coverity scan label Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant