[Refactor] Remove bip85 app num #809
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
ACK, tested, and reviewed. |
newtonick
moved this from 0.8.7 Needs Code Review
to 0.8.7 Merged
in @SeedSigner Development Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Given the discussion in #713 (and my other BIP-85 PR, #785), this PR removes
bip85_app_numfrom the BIP85 View.I agree with the points raised previously and don’t see any reasonable use case for other application types in the SeedSigner world.
Summary of changes:
bip85_app_numfrom the BIP85 View.SeedBIP85ApplicationModeViewtoSeedBIP85SelectNumWordsView.This pull request is categorized as a:
Checklist
pytestand made sure all unit tests pass before submitting the PRIf you modified or added functionality/workflow, did you add new unit tests?
I have tested this PR on the following platforms/os: