Skip to content

Conversation

@Sahil-Simform
Copy link
Contributor

Description

  • I have fixed overlapping event issue
  • Fixed the proper event arrangement issue when there is 4 consicutive events
  • Improved code quality and performance

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

@Sahil-Simform Sahil-Simform force-pushed the fix/improved_side_event_arranger branch from 8e04870 to 6108c1c Compare July 29, 2025 06:25
@ami-b-simform ami-b-simform requested review from ami-b-simform and removed request for ami-b-simform August 12, 2025 11:03
@ami-b-simform ami-b-simform force-pushed the fix/improved_side_event_arranger branch 3 times, most recently from 9e8d101 to 51b571b Compare August 12, 2025 12:21
@ami-b-simform ami-b-simform marked this pull request as ready for review August 13, 2025 06:51
@PRBaraiya PRBaraiya added the priority:1 Bug/Enhancement with highest priority. label Dec 23, 2025
@PRBaraiya PRBaraiya marked this pull request as draft December 24, 2025 07:44
@PRBaraiya
Copy link
Collaborator

Converting this PR to a draft as we need more improvements in the algorythm

@kavantrivedi kavantrivedi force-pushed the fix/improved_side_event_arranger branch from 51b571b to 21f1c46 Compare January 5, 2026 09:28
@kavantrivedi kavantrivedi force-pushed the fix/improved_side_event_arranger branch 2 times, most recently from 06cb588 to 7fb3955 Compare January 5, 2026 10:13
@kavantrivedi kavantrivedi requested a review from Copilot January 5, 2026 10:19
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the SideEventArranger class to fix overlapping event issues and improve event arrangement, particularly for scenarios with 4 consecutive events. The implementation replaces the previous recursive algorithm with a cleaner column-based approach.

Key changes:

  • Complete rewrite of the event arrangement algorithm using a first-fit column allocation strategy
  • Renamed includeEdges parameter to countAdjacentEventsAsOverlapping for better clarity
  • Added comprehensive documentation for all methods with edge case descriptions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@kavantrivedi kavantrivedi force-pushed the fix/improved_side_event_arranger branch from 7fb3955 to a6e9913 Compare January 5, 2026 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority:1 Bug/Enhancement with highest priority.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants