-
Notifications
You must be signed in to change notification settings - Fork 307
feat: 🚀 Fixed and improved side event arranger #488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
8e04870 to
6108c1c
Compare
9e8d101 to
51b571b
Compare
|
Converting this PR to a draft as we need more improvements in the algorythm |
51b571b to
21f1c46
Compare
06cb588 to
7fb3955
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR refactors the SideEventArranger class to fix overlapping event issues and improve event arrangement, particularly for scenarios with 4 consecutive events. The implementation replaces the previous recursive algorithm with a cleaner column-based approach.
Key changes:
- Complete rewrite of the event arrangement algorithm using a first-fit column allocation strategy
- Renamed
includeEdgesparameter tocountAdjacentEventsAsOverlappingfor better clarity - Added comprehensive documentation for all methods with edge case descriptions
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
7fb3955 to
a6e9913
Compare
Description
Checklist
fix:,feat:,docs:etc).docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues