-
Notifications
You must be signed in to change notification settings - Fork 4.4k
discover gpu resizable bar feature, faster weight upload #6536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6536 +/- ##
==========================================
- Coverage 92.94% 92.94% -0.01%
==========================================
Files 809 809
Lines 256714 256613 -101
==========================================
- Hits 238613 238508 -105
- Misses 18101 18105 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Adds a Vulkan-side capability probe for “Resizable BAR” (approximated via memory property inspection) and uses it to prefer more upload-friendly memory types for weight buffers/images to improve end-to-end performance.
Changes:
- Expose
GpuInfo::resizable_bar_enabled()as a new GPU property. - Cache/query physical device memory properties during GPU init and log
rebarstatus. - Adjust
VkWeightAllocatormemory-type selection to prefer device-local + host-visible allocations when ReBAR is detected.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/gpu.h | Adds GpuInfo::resizable_bar_enabled() API. |
| src/gpu.cpp | Implements memory-property query and derives/logs the ReBAR flag. |
| src/allocator.cpp | Uses the ReBAR flag to tweak weight allocation memory preferences. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Add comment explaining resizable bar behavior with memory types.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
z-image-ncnn 1024x1024