Skip to content

Add introductory panel and remove pop up card#692

Open
griseduardo wants to merge 3 commits intoTerrastories:masterfrom
griseduardo:675-add-introduction-panel
Open

Add introductory panel and remove pop up card#692
griseduardo wants to merge 3 commits intoTerrastories:masterfrom
griseduardo:675-add-introduction-panel

Conversation

@griseduardo
Copy link

@griseduardo griseduardo commented Oct 13, 2021

Motivation:
Add introductory panel and remove right pop up card

Solution:

  • Create Introductory Panel component
  • Remove Pop Up card
  • Create reusable Button component, to add 'EXPLORE' button
  • Create logic to change Introductory Panel to show stories

Issue:
#675

Opening page:
before-click-explore

After button click:
after-click-explore

PS: I updated all i18n languages using English

@griseduardo griseduardo changed the title Add introductionary panel and remove pop up card Add introductory panel and remove pop up card Oct 13, 2021
@griseduardo griseduardo force-pushed the 675-add-introduction-panel branch from 30e8d27 to e7a697c Compare October 13, 2021 00:35
@rudokemper
Copy link
Member

Hi @griseduardo, thanks for taking this one on. We haven't done a code review yet, but I just tested this PR out on the front and it looks really good!

I think there is just one additional change that we should make based on front-end testing: once a user selects an option in the second drop down, the intro panel should automatically disappear and the list of filtered cards revealed.

Otherwise, great work on this!

@griseduardo
Copy link
Author

Hi @griseduardo, thanks for taking this one on. We haven't done a code review yet, but I just tested this PR out on the front and it looks really good!

I think there is just one additional change that we should make based on front-end testing: once a user selects an option in the second drop down, the intro panel should automatically disappear and the list of filtered cards revealed.

Otherwise, great work on this!

Hello @rudokemper , thank you.
I updated with the change you presented.

@rudokemper
Copy link
Member

Awesome! Looks great. One final thing I just noticed is that we may want to adapt to the mobile view. Would it be easy and possible to hide this panel for mobile, for the time being? (Mobile UI is due for a redesign, where we'll consider how to incorporate this panel differently.)

@rudokemper
Copy link
Member

Also, sorry I didn't catch your question about i18n on the other thread. I think what you did was fine; we have to do some i18n updates to a number of the other languages anyway.

@griseduardo
Copy link
Author

Awesome! Looks great. One final thing I just noticed is that we may want to adapt to the mobile view. Would it be easy and possible to hide this panel for mobile, for the time being? (Mobile UI is due for a redesign, where we'll consider how to incorporate this panel differently.)

One question, do you want to hide the introductory panel and return the stories when in mobile? (like it was before my changes)

@rudokemper
Copy link
Member

Yeah, for the time being let's do that for Mobile. Since we have to do a redesign of the Mobile UI anyway.

If you ended up doing some custom code for mobile specifically, please just comment that out so we can use it later.

@griseduardo
Copy link
Author

Yeah, for the time being let's do that for Mobile. Since we have to do a redesign of the Mobile UI anyway.

If you ended up doing some custom code for mobile specifically, please just comment that out so we can use it later.

Ok, I updated to show the stories when in mobile device

@rudokemper
Copy link
Member

Thanks so much @griseduardo, I appreciate you iterating on this.

@lauramosher @FeminismIsAwesome mind doing a code review on this one?

@rudokemper rudokemper linked an issue Oct 13, 2021 that may be closed by this pull request
4 tasks
@rudokemper rudokemper added hacktoberfest-accepted waiting for code review Terrastories stewards need to check the code for final approval. labels Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted waiting for code review Terrastories stewards need to check the code for final approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[React] Create an introductory panel before displaying the StoryList in Map view

3 participants