-
Notifications
You must be signed in to change notification settings - Fork 2
Replace fill() with FillArrays.Fill() in product_distribution calls
#67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace fill() with FillArrays.Fill() in product_distribution calls
#67
Conversation
Co-authored-by: yebai <[email protected]>
Co-authored-by: yebai <[email protected]>
fill() with FillArrays.Fill() in product_distribution calls
Co-authored-by: yebai <[email protected]>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Co-authored-by: yebai <[email protected]>
|
could you move the FillArrays import back into the models please since it's meant to be code that you can copy paste after doing |
|
Sure, @copilot |
|
oh do I need to ping copilot to make it do stuff? |
|
I thought my comment would be enough 😄 |
|
Yes, just at copilot. |
Co-authored-by: yebai <[email protected]>
Done in commit 00bcfbc. Moved |
|
Thanks for cleaning up the issues! |
Replaces generic
fill()with explicitFillArrays.Fill()constructor in allproduct_distribution()calls for better type stability.Changes
dppl_lda.jl(2)dppl_hmm_semisup.jl(2)dppl_high_dim_gauss.jl,dppl_naive_bayes.jl,dppl_hier_poisson.jl,dppl_gauss_unknown.jl,demo_assume_matrix_observe_matrix_index.jl(1 each)using FillArraysto each of the 6 model files for copy-paste compatibilityBefore:
theta ~ product_distribution(fill(Dirichlet(alpha), K))After:
The
using FillArraysimport is included in each model file so the code can be copy-pasted afterusing Turingwithout missing import errors.Original prompt
product_distribution(fill(d, ns...))withproduct_distribution(FillArrays.Fill(d, ns...))#47💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.