More type safety for language keys #93
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctions and operators
…ting definitions even more
…anguageNode`, wrote documentation about validation
Lotes
reviewed
Jan 20, 2026
Collaborator
Lotes
left a comment
Lotes
left a comment
There was a problem hiding this comment.
I like the type specific bundle. It gives the opportunity to carry along language-specific types, similar to the dependency injection, which bundles values of services.
I also like those lookup functions, so that you do not have to break apart the specifics on your own.
Most stuff is a replacement for the old types, but I found one little thing, where I wonder if we can make this better.
| * otherwise the given options are used to register the return validation rule now. | ||
| */ | ||
| registration: 'MYSELF' | Partial<ValidationRuleOptions>; | ||
| registration: 'MYSELF' | Partial<ValidationRuleOptions<Specifics>>; |
Collaborator
There was a problem hiding this comment.
This MYSELF feels weird. Is the user not free in using this API? At a different position you are checking if it is MYSELF only in order to skip something. I am wondering if that can be done differently. Looks hacky, but have no better arguments ^^
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR increases the TypeScript type-safety and can be seen as a follow-up of #90
TypirSpecificsnow contain the propertyLanguageKeys: Record<string, unknown>;to make language keys explicit. This is the precondition for the following improvements:Specifics['LanguageKeys']to simplify inference rules for functions and operators: Now it is possible to skip the TypeScript type when using onlylanguageKeyand nofilter. @Lotes You sketched this idea some time ago and now we have everything to make your idea happen 🙂Contributions of this PR which are not related to language keys:
languagePropertysupports only valid property names of the givenlanguageNodeOpen issues:
Specifics['LanguageKeys']now even in Typir (core), we could support the featuresaddValidationRulesForAstNodesandaddInferenceRulesForAstNodes(which are Typir-Langium only so far) also in Typir (core): I would prefer that (but did not implement that yet), what do you think?typir.ts, there are two open issues/improvements marked with// possible extension, for which I found no solution so farI recommend to review this PR commit by commit.