Fix duplicate stop hooks display in Claude #38
Merged
+511
−75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The policy_stop_hook.sh was passing --changed-files argument to the
Python evaluate_policies module, but the module doesn't accept this
argument. This caused argparse to fail, which was suppressed by
`2>/dev/null || echo '{}'`, resulting in the hook always outputting
empty JSON instead of blocking JSON when policies fire.
Changes:
- Sync installed hooks (.deepwork/jobs/) with source (src/deepwork/standard_jobs/)
- Remove obsolete get_changed_files.sh and capture_work_tree.sh
- Add capture_prompt_work_tree.sh for compare_to: prompt mode
- Add shell script tests in tests/shell_script_tests/ to verify
the hook correctly outputs blocking JSON when policies fire
Running `deepwork install` synced several updates from source: - Added browser automation capability guidance to job definition steps - Added supplemental_file_references.md documentation - Updated generated commands in .claude/ and .gemini/
nhorton
commented
Jan 15, 2026
- Update architecture.md to reflect current hook files: - capture_work_tree.sh → capture_prompt_work_tree.sh - Removed get_changed_files.sh (logic in Python evaluator) - Add Fixed section to CHANGELOG for stop hook blocking bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The policy_stop_hook.sh was passing --changed-files argument to the Python evaluate_policies module, but the module doesn't accept this argument. This caused argparse to fail, which was suppressed by
2>/dev/null || echo '{}', resulting in the hook always outputting empty JSON instead of blocking JSON when policies fire.Changes: