Skip to content

Addon: [1.8.0] - Add support Legacy Cataclysm 4.3.4 client #723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Xian55 merged 30 commits into from
Jan 8, 2026
Merged

Addon: [1.8.0] - Add support Legacy Cataclysm 4.3.4 client #723

Xian55 merged 30 commits into from
Jan 8, 2026

Conversation

@Xian55
Copy link
Owner

@Xian55 Xian55 commented Jan 8, 2026 •
edited
Loading

Key Changes:

  • Initial support for 4.3.4 client version support
  • Improved supporting multiple client versions (read the readme for currently known supported versions)

Known issue:

  • For Legacy Cataclysm client 4.3.4 version i had to override the DPI settings in order the game client report the proper resolution. (the game window was 1024x786 - however it was reported as 1280x960 - while i had a 4K monitor with 1.5 GUI scale)

Xian55 added 30 commits October 19, 2025 17:02
@Xian55
Add initial support for 4.3.4 client version support
bf690b3
@Xian55
Fix UnitIsTapDenied
6c72a0f
@Xian55
Add initial support for 4.3.4 client version support
35559bb
@Xian55
Fix UnitIsTapDenied
85ce1b3
@Xian55
Merge branch 'backport/4.3.4' of github.com:Xian55/WowClassicGrindBot…
0541596 
… into backport/4.3.4
@Xian55
Merge branch 'dev' into backport/4.3.4
ab9bf42
@Xian55
Addon: LibRangeCheck-3.0.lua: Updated to latest minor 28 - added fix …
dad1047 
…for tbc 2.5.2.40892 C_Item.GetItemInfo missing api
@Xian55
Added two backports to make BindPad working for Cataclysm 4.3.4 version
d50dac0
@Xian55
Addon: 1.8.0 - Version: Supports Legacy Cata client. Classic clients …
77b1de0 
…use the WOW_PROJECT_ID for Legacy clients calculate it.

Addon: Query: Guid based version specific code has moved to Versions
@Xian55
Core: PlayerReader.Version has 2 digits to support Legacy and Classic…
a4ea426 
… versions at the same time.

Core: BotController: Show the ClientVersion on startup.

Game: WoWProcess: Better Version detection from FileVersionInfo
@Xian55
SharedLib: ClientVersion: Let the WOW_PROJECT_ID drive the client ver…
81c0756 
…sion for Classic client
@Xian55
SoundKitBackport uses a UI safe implementation
c73df9a
@Xian55
Addon: IsInGroup backport
65a3674
@Xian55
Addon: DataToColor: has load order dependency on cTimerBackport
e0aacfe
@Xian55
Addon: Use lua varargs for the following functions
85f2681 
* OnUIErrorMessage
* OnUnitSpellCastSent
* OnUnitSpellCastSucceeded
* OnUnitSpellCastFailed
@Xian55
Fix SpellBook and Inventory extraction in legacy Cataclysm client
6e05be3
@Xian55
* Addon: Added WorldMapAreaIDToUiMapID - Legacy Cataclysm returns wit…
2cd2a2e 
…h the WorldMapAreaId meanwhile DataToColor expects to return with iuMapId

* .bat\Generate-WorldMapMapping.ps1: Added generator
* Core: TalentDB: allow to use empty dataset
* SharedLib: StartupClientVersion: use more sophisticated version detection, allows to support Legacy dataset.
@Xian55
Json: legacy_cata minimum dataset added
f86ff20
@Xian55
Addon: Legacy Version returns textures as file path, however prefer t…
f5516ff 
…o use filePathID
@Xian55
Addon: Version: Only load LegacyTextureToFileID when C_Map does not e…
52e8d80 
…xists
@Xian55
Addon: Use ChatEdit_GetActiveWindow over ChatFrame1EditBox
f6ce9d2
@Xian55
Addon: Refactor UnitCastingInfo and UnitChannelInfo
ae1d1e5
@Xian55
4.3.4 Fix: GetSpellInfo: min-max Range are the 8-9 return values
2a42e2b
@Xian55
4.3.4 LibRangeCheck Fix: Only include IsSpellKnown
02b92ef
@Xian55
Backport DataToColor addon to Cataclysm 4.3.4 legacy client
e850fb0 
  - Fix CombatLog event handling for 4.3.4 API (no CombatLogGetCurrentEventInfo)
  - Fix IsUsableAction return values (1/nil vs true/false)
  - Fix legacy GUID parsing format (0xF130XXXX...)
  - Add GetActionTexture version wrapper
  - Update RangeCheck library loading to use 2.0 on legacy
  - Remove modern Classic TOC files
  - Update backport addon interfaces to 40300
  - LibRangeCheck-2.0 should work properly
  - The character should be able to use abilities based on the requirements
@Xian55
Addon: Fix an issue when the BagSlotChange were not properly detected
a8611ad
@Xian55
Addon: Client 4.3.4 use LibRangeCheck-2.0 Revision 124
1485c70
@Xian55
Addon: Client 4.3.4 - Fix PlayerMovement flag was not detected proper…
9b95afa 
…ly - Fix GossipOptions
@Xian55
Addon: Client 4.3.4 - Detect Modern and Legacy GossipOptions during r…
11aed35 
…untime. Classic ~2.5.2 clients does not support '_Classic.toc' files
@Xian55
Readme: Update with currently supported versions
93731b8
@Xian55 Xian55 added documentation Improvements or additions to documentation enhancement This pull request implements a new feature. dependencies Pull requests that update a dependency file labels Jan 8, 2026
@Xian55 Xian55 merged commit 3900abb into dev Jan 8, 2026
1 check passed
@Xian55 Xian55 mentioned this pull request Jan 8, 2026
Open
@Xian55 Xian55 linked an issue Jan 8, 2026 that may be closed by this pull request
3.3.5 / 4.3.4 backport #704
Open
@Xian55 Xian55 deleted the backport/4.3.4 branch January 10, 2026 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

breaking change dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation enhancement This pull request implements a new feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3.3.5 / 4.3.4 backport

2 participants

@Xian55