Skip to content

Conversation

@oneInsect
Copy link

@oneInsect oneInsect commented Jan 15, 2026

Description

Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Follow the CONTRIBUTING Guide.
  • Make your Pull Request title in the https://www.conventionalcommits.org/ specification.
    • Important Prefixes for release-please:
      • fix: which represents bug fixes, and correlates to a SemVer patch.
      • feat: represents a new feature, and correlates to a SemVer minor.
      • feat!:, or fix!:, refactor!:, etc., which represent a breaking change (indicated by the !) and will result in a SemVer major.
  • Ensure the tests and linter pass (Run bash scripts/format.sh from the repository root to format)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@oneInsect oneInsect requested a review from a team as a code owner January 15, 2026 12:57
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @oneInsect, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a bug where the rejected task state was not correctly handled during the bidirectional conversion between the application's internal TaskState representation and its Protobuf counterpart. By adding the necessary mapping for this state in both directions, the change ensures that the rejected status is accurately preserved when tasks are serialized to and deserialized from Protobuf messages, preventing potential data inconsistencies or incorrect state handling.

Highlights

  • Task State Conversion: Added the missing rejected state to the conversion logic from the internal types.TaskState enum to the a2a_pb2.TaskState Protobuf enum.
  • Task State Conversion: Implemented the reverse conversion for the rejected state, mapping a2a_pb2.TaskState.TASK_STATE_REJECTED back to types.TaskState.rejected.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly adds the missing mapping for the rejected task state in both the ToProto.task_state and FromProto.task_state methods. The changes are straightforward and address the issue described. I've added a comment regarding updating the unit tests to cover this new case.

Comment on lines +233 to +234
case types.TaskState.rejected:
return a2a_pb2.TaskState.TASK_STATE_REJECTED
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

This new case for types.TaskState.rejected is correct. To ensure this change is properly tested, please update the test_enum_conversions unit test in tests/utils/test_proto_utils.py. The test currently excludes types.TaskState.rejected from the round-trip conversion check. Please update the test to include this new state to ensure it's properly covered.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the tests

Copy link
Member

@holtskinner holtskinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check to ensure this isn't already covered in #572

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants