Fix #4576: Add BSD license detection rule for JLine XML comments #4681
+19
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4576
Problem
ScanCode failed to detect BSD-3-Clause license in JLine packages (jline-console, jline-style, jline-reader) because the license is declared in XML comments rather than standard Maven
<licenses>tags.Solution
Added detection rule bsd-new_jline_xml.RULE to recognize the specific BSD license notice pattern found in JLine project POM files.
Testing
✅ Verified detection on jline-console-3.30.4-sources.jar
The same pattern appears in jline-style and jline-reader, so this rule covers all three packages.
Changes
✅ Verification Complete - BSD License Detection Working
I've verified the fix works correctly with the actual JLine package from Maven Central.
Test Results
Package tested:
jline-console-3.30.4-sources.jarfrom Maven CentralBefore fix:
After fix:
bsd-new(BSD-3-Clause)bsd-new_jline_xml.RULEMETA-INF/maven/org.jline/jline-console/pom.xmlEvidence
The POM file contains:
ScanCode now correctly detects this as BSD-3-Clause using the custom rule.
The BSD license detection fix is working as intended and ready for merge. ✅ETA-INF/maven/org.jline/jline-console/pom.xml
Tasks
Signed-off-by: NullPointer-cell [email protected]