Skip to content

[REDCap] Handle empty data gracefully in notifications endpoint (#9895) #10257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
driusan merged 1 commit into from
Jan 20, 2026
Merged

[REDCap] Handle empty data gracefully in notifications endpoint (#9895) #10257

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions modules/redcap/php/endpoints/notifications.class.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,12 @@ class Notifications extends Endpoint
$data = json_decode((string) $request->getBody(), true);
}

// Handle empty data gracefully (e.g., REDCap DET "Test" button sends
// empty data).
Comment on lines +111 to +112
Copy link
Contributor

@MaximeBICMTL MaximeBICMTL Jan 17, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Handle empty data gracefully (e.g., REDCap DET "Test" button sends
// empty data).
// Return an empty response when receiving empty data, which is notably
// sent by the test button of the REDCap data entry trigger.

Nit (optional): I personally do not like to use subjective wording (like "gracefully") or acronyms in code comments. But that may be a matter of personal taste, the PR is good.

if ($data === null || $data === []) {
return new \LORIS\Http\Response();
}

try {
$received_datetime = new \DateTimeImmutable();

Expand Down
Loading