[OID4VCI] Restructure credential_configurations_supported parsing to handle credential_metadata with display and claims && Update Credential Issuer Metadata structure#102
Conversation
services/src/main/java/org/keycloak/protocol/oid4vc/model/DisplayObject.java
Show resolved
Hide resolved
services/src/main/java/org/keycloak/protocol/oid4vc/model/DisplayObject.java
Show resolved
Hide resolved
|
I did most of the work on this PR: #103 that contains credential_request_encryption and credential_response_encryption see tickets awell: Perhaps you could refer my PR link for clarification, let's avoid double work. Aside that, this PR LDTM ! |
IngridPuppet
left a comment
There was a problem hiding this comment.
Added some comments. Please could you check?
services/src/main/java/org/keycloak/protocol/oid4vc/issuance/OID4VCIssuerWellKnownProvider.java
Outdated
Show resolved
Hide resolved
services/src/main/java/org/keycloak/protocol/oid4vc/issuance/OID4VCIssuerWellKnownProvider.java
Outdated
Show resolved
Hide resolved
services/src/main/java/org/keycloak/protocol/oid4vc/issuance/OID4VCIssuerWellKnownProvider.java
Show resolved
Hide resolved
services/src/main/java/org/keycloak/protocol/oid4vc/model/CredentialIssuer.java
Show resolved
Hide resolved
services/src/main/java/org/keycloak/protocol/oid4vc/model/DisplayObject.java
Outdated
Show resolved
Hide resolved
...t/java/org/keycloak/testsuite/oid4vc/issuance/signing/OID4VCIssuerWellKnownProviderTest.java
Outdated
Show resolved
Hide resolved
I'm afraid the double work, if any, is already done. Given the significant progress on this PR, you could just indeed sync on overlapping changes so it is straightforward to resolve conflicts to arise in the future. |
services/src/main/java/org/keycloak/protocol/oid4vc/issuance/OID4VCIssuerWellKnownProvider.java
Outdated
Show resolved
Hide resolved
…dential_metadata with display and claims && Update Credential Issuer Metadata structure Closes: keycloak#41587 Closses: keycloak#41597 Signed-off-by: forkimenjeckayang <forkimenjeckayang@gmail.com>
1517055 to
9d34a3e
Compare
Signed-off-by: forkimenjeckayang <forkimenjeckayang@gmail.com>
bda0e2a to
f99c912
Compare
Summary
Implements complete OID4VCI draft-16 specification changes for Credential Issuer Metadata, including restructured
credential_configurations_supportedwithcredential_metadataand newcredential_request_encryptionsupport.Key Changes
CredentialMetadataclass: Container for display and claims metadataSupportedCredentialConfiguration: Removed directdisplayandclaimsfields, addedcredential_metadatafieldDisplayObject: Added support forbackground_imageand enhancedlogoobject structureCredentialRequestEncryptionMetadata: Supports credential request encryption with JWKS, algorithms, and compressionCredentialResponseEncryptionMetadata: Addedzip_values_supportedfieldCredentialIssuer: Addedcredential_request_encryptionfieldBreaking Changes
SupportedCredentialConfiguration.getDisplay()andgetClaims()methods removedgetCredentialMetadata().getDisplay()andgetCredentialMetadata().getClaims()credential_metadataSpecification Compliance
Closses