Skip to content

[OID4VCI]: Add UI support for vc.credential_signing_alg_values_supported in OID4VCI client scopes#205

Draft
forkimenjeckayang wants to merge 5 commits intomainfrom
vc-signing-algs-ui
Draft

[OID4VCI]: Add UI support for vc.credential_signing_alg_values_supported in OID4VCI client scopes#205
forkimenjeckayang wants to merge 5 commits intomainfrom
vc-signing-algs-ui

Conversation

@forkimenjeckayang
Copy link
Collaborator

Summary

Adds frontend support for configuring vc.credential_signing_alg_values_supported attribute in OID4VCI client scopes. This attribute was recently renamed from proof_signing_alg_values_supported on the backend.

Changes

  • Added TextControl field in ScopeForm.tsx for vc.credential_signing_alg_values_supported with comma-separated list validation
  • Added translation strings (credentialSigningAlgorithmsSupported and credentialSigningAlgorithmsSupportedHelp) to messages_en.properties
  • Extended Playwright tests to verify field visibility, persistence, and proper hiding when OID4VCI protocol is not selected

Closses

@forkimenjeckayang
Copy link
Collaborator Author

This branch takes root from feat/oid4vci-signing-alg-rename but can be removed based on this commit 010ca21

Copy link
Collaborator

@IngridPuppet IngridPuppet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll have to create the upstream Keycloak ticket and indicate the dependence on keycloak#44621

@IngridPuppet
Copy link
Collaborator

There is a move to make the configuration property singular from vc.credential_signing_alg_values_supported to vc.credential_signing_alg. See #212.

@forkimenjeckayang - Please could you update this PR accordingly? In particular, pay attention to labels and descriptions.

@forkimenjeckayang
Copy link
Collaborator Author

There is a move to make the configuration property singular from vc.credential_signing_alg_values_supported to vc.credential_signing_alg. See #212.

@forkimenjeckayang - Please could you update this PR accordingly? In particular, pay attention to labels and descriptions.

Definitely @IngridPuppet , thank you for mentioning

@forkimenjeckayang forkimenjeckayang force-pushed the vc-signing-algs-ui branch 3 times, most recently from 29a7045 to 2f9b741 Compare December 22, 2025 07:38
Closes: keycloak#44849
Signed-off-by: forkimenjeckayang <forkimenjeckayang@gmail.com>
Signed-off-by: forkimenjeckayang <forkimenjeckayang@gmail.com>
Signed-off-by: forkimenjeckayang <forkimenjeckayang@gmail.com>
Signed-off-by: forkimenjeckayang <forkimenjeckayang@gmail.com>
Signed-off-by: forkimenjeckayang <forkimenjeckayang@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add UI Support for vc.credential_signing_alg_values_supported in OID4VCI Client Scopes

2 participants