[OID4VCI]: Use Keycloak time utility for OID4VC related timestamps#207
Draft
forkimenjeckayang wants to merge 2 commits intomainfrom
Draft
[OID4VCI]: Use Keycloak time utility for OID4VC related timestamps#207forkimenjeckayang wants to merge 2 commits intomainfrom
forkimenjeckayang wants to merge 2 commits intomainfrom
Conversation
Collaborator
IngridPuppet
left a comment
There was a problem hiding this comment.
Just a minor comment
services/src/main/java/org/keycloak/protocol/oid4vc/issuance/keybinding/JwtCNonceHandler.java
Outdated
Show resolved
Hide resolved
IngridPuppet
approved these changes
Dec 11, 2025
Collaborator
IngridPuppet
left a comment
There was a problem hiding this comment.
Please just send the PR after updating.
services/src/main/java/org/keycloak/protocol/oid4vc/issuance/keybinding/JwtCNonceHandler.java
Outdated
Show resolved
Hide resolved
7891999 to
e022d07
Compare
Closes: keycloak#44235 Signed-off-by: forkimenjeckayang <forkimenjeckayang@gmail.com>
Signed-off-by: forkimenjeckayang <forkimenjeckayang@gmail.com>
d61a69f to
726f326
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closses