Cleanup alienv file #1445
Open
Cleanup alienv file #1445
+77
−81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patch generated with `shellcheck -f diff cvmfs/alienv | git apply`
ktf
requested changes
Mar 11, 2025
Member
ktf
left a comment
ktf
left a comment
There was a problem hiding this comment.
Too much of a change. Please split it in multiple PRs.
Merged
ktf
pushed a commit
that referenced
this pull request
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch mostly generated with
shellcheck -f diff cvmfs/alienv | git applyandthen manually removed some unused variables
I want to do several improvements here, but seeing as it's a sensitive script,
I'd like to do them gradually
I haven't been able to find behaviour differences between this and the one
in CVMFS
CC @ktf
I will reflect the change in CVMFS after merge