Fix gradle sync error by updating foojay plugin version #770
Conversation
…ync due to this issue: https://youtrack.jetbrains.com/projects/KTIJ/issues/KTIJ-36077/Project-sync-error-with-JvmVendorSpec-does-not-have-member-field-org.gradle.jvm.toolchain.JvmVendorSpec-IBMSEMERU-error Updating the foojay plugin to 1.0.0, and gradle to 9.2.1 solves the issue.
Summary of ChangesHello @dturner, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical Gradle sync error by performing essential updates to the project's build configuration. It specifically targets an issue with Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Gradle wrapper and the foojay-resolver-convention plugin to fix a Gradle sync error. The changes are correct and address the issue. I've included one suggestion to improve maintainability by centralizing the plugin version in the Gradle version catalog, which aligns with the project's existing dependency management strategy.
| } | ||
| plugins { | ||
| id("org.gradle.toolchains.foojay-resolver-convention") version "0.8.0" | ||
| id("org.gradle.toolchains.foojay-resolver-convention") version "1.0.0" |
There was a problem hiding this comment.
For better maintainability and consistency with the project's dependency management, I recommend moving this plugin's version to the Gradle version catalog (gradle/libs.versions.toml).
First, add the version to gradle/libs.versions.toml:
[versions]
foojay-resolver = "1.0.0"Then, you can apply the code suggestion below to reference it from the catalog. This will make future version updates easier to manage.
id("org.gradle.toolchains.foojay-resolver-convention") version libs.versions.foojay.resolver.get()
There was a problem hiding this comment.
@dturner Can you move the dependency version to the Gradle catalog?
2 participants
Related issue: https://youtrack.jetbrains.com/projects/KTIJ/issues/KTIJ-36077/Project-sync-error-with-JvmVendorSpec-does-not-have-member-field-org.gradle.jvm.toolchain.JvmVendorSpec-IBMSEMERU-error