change client_max_body_size var type to integer #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| type: string | ||
| description: Sets the maximum allowed size of the client request body in megabytes (defaults to 10M) | ||
| default: 10 | ||
| type: integer |
Member
There was a problem hiding this comment.
The galaxy-operator change would be a breaking change for anyone who is currently setting nginx_client_max_body_size on their Galaxy.spec right if I understand correctly.
I don't think we should do a breaking change like this until we can cut a new apiVersion for the Galaxy CRD. So I think we need to make it backwards compatible if we are going to merge this. And since the validation happens on the CRD when it is applied, I don't see a clean way to add backwards compatibility without adding a new apiVersion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR try to make it more consistent with the type we use in the awx-operator and to prevent input user errors due to the possibility of entering any value when defining it in the CR, as the variable allows the string type.
ADDITIONAL INFORMATION
This change was also applied to the
awx-operatorrepository, and during a discussion in the PR submitted to that repository, we concluded that it might be interesting to apply the same change here in thegalaxy-operator.#182
ansible/awx-operator#2014