Fix JSON marshaling for custom content citations#225
Open
mhpenta wants to merge 3 commits intoanthropics:mainfrom
Open
Fix JSON marshaling for custom content citations#225mhpenta wants to merge 3 commits intoanthropics:mainfrom
mhpenta wants to merge 3 commits intoanthropics:mainfrom
Conversation
Author
|
Has anyone reviewed this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When using document blocks with custom content for citations, the SDK was not marshaling the content correctly. The API expects content blocks to be formatted as [{"type": "text", "text": "..."}], but the SDK was sending malformed JSON for string arrays.
Solution
Added custom MarshalJSON implementation for BetaContentBlockSourceContentUnionParam that detects when content blocks contain strings and transforms them into the proper text block format expected by the Anthropic API. (I implemented a similar feature in https://github.com/liushuangls/go-anthropic.)
Testing
This fix enables citations to work correctly with custom document content blocks.