Skip to content

Conversation

@vighneshtule
Copy link
Contributor

@vighneshtule vighneshtule commented Jan 12, 2026

This PR adds End-to-End (E2E) tests for the Calendar tab on the DAG details page.

Changes:

  • Modified DagsPage.ts to include locators for the Calendar tab and grid, and added a verifyCalendarTab method.
  • Added dag-calendar.spec.ts to verify:
    • Navigation to the Calendar tab.
    • Visibility of the month grid.
    • Presence of run markers (filled cells) after triggering a DAG run.
    • Interactivity of run markers (clicking).

related: #59544

Was generative AI tooling used to co-author this PR?

  • Yes

@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Jan 12, 2026
@vighneshtule
Copy link
Contributor Author

Hey maintainers,
I would really appreciate it if you could review this PR and share any suggestions on how I can improve it further. Thank you!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the static checks and e2e tests are failing. Could you please check on this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey its getting hard for me to resolve this checks would anyone like to help me out

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vighneshtule could you elaborate more on what issues you are facing fixes the failures?

vighneshtule and others added 14 commits January 16, 2026 02:18
…he#60357)

* Simplify metric names construction in BaseExecutor emit_metrics

* update _get_metric_name
…low 2 (apache#56406)

* add a recent configrations drop down list

* remove extra files

* refactor: change trigger config UX from dropdown to menu button

- Remove RecentConfigurationsDropdown component
- Add menu option 'Trigger again with this config' to Trigger button
- Pre-fill form with selected DAG Run configuration
- Revert unnecessary API changes for recent configurations
- Update translations for new menu option

* follow suggestions for 409 conflict

* follow suggestions and pick up types

* fix the staticcheck error
* Update Dutch translations (2026-01-15)

* Update airflow-core/src/airflow/ui/public/i18n/locales/nl/common.json

---------

Co-authored-by: Bas Harenslak <BasPH@users.noreply.github.com>
* i18n(zh-TW): add missing translations

* adjust translation
* add result count to dag run and ti tabs

* conditionally render filter count if count > 0

* remove unused translate

* add optional ToggleTableDisplay element to DataTable component

* move ToggleTableDisplay to DataTable

* make datatable showRowCountHeading default to true and change modelName to required. update datatable users to disable the heading based on if they have pluralizable model keys
- Create DagCalendarPage with calendar-specific test methods
- Add test spec covering calendar render, run status display, and filtering
- Add data-testid and data-date attributes to Calendar components
- Preserve existing data-count attribute on calendar cells
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.