change: remove lua-resty-worker-events #12930
Open
+87
−785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abhishek Choudhary <shreemaan.abhishek@gmail.com>
dosubot
bot
added
size:XL
| "http_failures": 1 | ||
| } | ||
| local core = require("apisix.core") | ||
| local route_config = { |
Contributor
Author
There was a problem hiding this comment.
I had to convert json config to lua table to get rid of this error in CI:
nic-6443
reviewed
Jan 22, 2026
Comment on lines
-18
to
-22
| BEGIN { | ||
| if ($ENV{TEST_EVENTS_MODULE} ne "lua-resty-worker-events") { | ||
| $SkipReason = "Only for lua-resty-worker-events events module"; | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Why can this test case only run using lua-resty-worker-events?
Contributor
Author
There was a problem hiding this comment.
the deleted test cases have their counterparts that can run under lua-resty-events.
nic-6443
approved these changes
Jan 22, 2026
Contributor
|
Should we discuss this change on the mailing list? It appears to be a breaking change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#10550 implemented support for
lua-resty-events, it's been long since; so we can remove the old events module lua-resty-worker-events.Checklist