-
Notifications
You must be signed in to change notification settings - Fork 4k
GH-34785: [C++][Parquet] Add bloom filter write support #37400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
pitrou
merged 98 commits into
apache:main
from
mapleFU:parquet/support-write-bloom-filter
Jan 14, 2026
Merged
Changes from 96 commits
Commits
Show all changes
98 commits
Select commit
Hold shift + click to select a range
f1c6dc0
Parquet: Implement skeleton for BloomFilter
mapleFU 6ebd6da
tiny fixing
mapleFU 70c9267
tiny update test
mapleFU 48350d8
trying to fix ci
mapleFU d2a659e
fix lint
mapleFU 41236d8
fix some style problem
mapleFU 8afba81
add file roundtrip test
mapleFU 96c6691
add file roundtrip test
mapleFU c131341
fix document and ci
mapleFU 220b58e
Update: tiny style fix
mapleFU ad96c48
Merge branch 'main' into parquet/support-write-bloom-filter
mapleFU b756241
Bloom Filter Resolve comments:
mapleFU f43505b
make space writing a batched writing
mapleFU 3497f4a
update bloom_filter builder interface
mapleFU fecd0f0
update BloomFilterBuilder arguments
mapleFU 29cc1c1
fix compile
mapleFU ffbb491
try to satisfy win compiler
mapleFU 4d63428
change all to vector
mapleFU f689716
Merge branch 'main' into parquet/support-write-bloom-filter
mapleFU 8e9cb16
resolve comment
mapleFU 7fd47be
Merge branch 'main' into parquet/support-write-bloom-filter
mapleFU 7c4ff4e
Merge branch 'main' into parquet/support-write-bloom-filter
mapleFU feccee9
fix some comment
mapleFU 90245e7
add cached version test
mapleFU d924e36
cleaning the code for column-props
mapleFU 0340193
optimize get bf
mapleFU b78eed0
Merge branch 'main' into parquet/support-write-bloom-filter
mapleFU 23828e1
comment minor fix
mapleFU 6fd57dc
fix comment and add bloom-filter-length
mapleFU 86a8760
Fix a bf bug
mapleFU f8e724c
trying to use std::map for RowGroup filter
mapleFU 447badf
trying to fix msvc compile
mapleFU 0c1065c
fix comment
mapleFU 5225e08
add test case for 2 row-groups
mapleFU a779982
add test case for dictionary
mapleFU 4195406
minor update style for file_writer.cc
mapleFU ed267bd
Merge branch 'main' into parquet/support-write-bloom-filter
mapleFU 478889d
resolve comment
mapleFU 2992072
fix comment for boolean col, and add test
mapleFU 4852261
trying to add bloom boolean test
mapleFU add1afd
fix test
mapleFU f627e30
Merge branch 'main' into parquet/support-write-bloom-filter
mapleFU bb8d4a5
fix some comments
mapleFU ad0f1af
Merge branch 'parquet/support-write-bloom-filter' of github.com:maple…
mapleFU e1de5bc
fix lint
mapleFU 430742a
switch to anonymous namespace
mapleFU 00f176e
fix comment for column_writer.cc
mapleFU 17f4951
fix comment in other parts
mapleFU de27ce4
Merge branch 'main' into parquet/support-write-bloom-filter
mapleFU 259f15b
Merge branch 'main' into parquet/support-write-bloom-filter
mapleFU 057b542
Merge branch 'main' into parquet/support-write-bloom-filter
mapleFU 34a4c28
trying to fix the ci build
mapleFU 70e3508
Merge branch 'main' into parquet/support-write-bloom-filter
mapleFU c587568
resolve comments
mapleFU 2223423
Merge branch 'main' into parquet/support-write-bloom-filter
mapleFU 22030db
change the bloom filter from vector to map
mapleFU e9c550a
fix lint
mapleFU 23fb3fa
fix lint
mapleFU d892819
fix comment
mapleFU ef3291d
Merge branch 'main' into parquet/support-write-bloom-filter
mapleFU 7aee7dd
Merge branch 'main' into parquet/support-write-bloom-filter
mapleFU c5b1fb1
Resolve comments
mapleFU 0898466
Merge branch 'main' into parquet/support-write-bloom-filter
mapleFU 71f5906
Merge branch 'main' into parquet/support-write-bloom-filter
mapleFU d57ceea
minor fix
mapleFU 26c2d07
address some comments
mapleFU d422ffa
Merge branch 'main' into parquet/support-write-bloom-filter
mapleFU e6bc6e1
Minor fix
mapleFU dfaf0e8
try to fix lint
mapleFU 0bafe78
Merge branch 'main' into parquet/support-write-bloom-filter
mapleFU ce30ebc
Resolve comment part1
mapleFU 8286783
Merge branch 'main' into parquet/support-write-bloom-filter
mapleFU b079acb
Merge branch 'main' into parquet/support-write-bloom-filter
mapleFU 3a5a491
Extract a BloomFilterWriterImpl, and supports binary-view type
mapleFU cccb9a8
test for string_view type
mapleFU 3cf9425
Merge branch 'main' into parquet/support-write-bloom-filter
mapleFU aac454e
Fix comment part1
mapleFU 83999cd
add writer_internal for bf
mapleFU fa0c9b1
try to fix ci
mapleFU 351da07
Trying to fix lint
mapleFU 12364d0
Remove duplicate code
mapleFU 8dec902
Merge branch 'parquet/support-write-bloom-filter' of https://github.c…
mapleFU 40c9079
Merge branch 'main' into parquet/support-write-bloom-filter
mapleFU d32c40b
Apply suggestions
mapleFU a662563
apply suggestions
mapleFU 61b6dff
fix lint
mapleFU 18f1a47
Update: remove some , and fix include
mapleFU 2bfa278
Merge remote-tracking branch 'origin' into parquet/support-write-bloo…
wgtmac f03a327
address comments
wgtmac 4aeff8b
Merge remote-tracking branch 'origin' into parquet/support-write-bloo…
wgtmac 0f50418
address comments
wgtmac 789d130
address comments
wgtmac 6dc8d88
add template definition back
wgtmac 0940cd8
Merge branch 'main' into parquet/support-write-bloom-filter
wgtmac a126e03
polish test and address feedback
wgtmac e560a28
address more comments
wgtmac bf5e859
update table
wgtmac 0638b11
update table
wgtmac File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.