Consolidate filters and projections onto TableScan
#20061
+1,465
−1,387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sql
adriangb
commented
Jan 29, 2026
Comment on lines
+1757
to
+1758
| // Wrap with ProjectionExec if projection is present and differs from scan output | ||
| // (either non-identity, or fewer columns due to filter-only columns) |
Contributor
Author
There was a problem hiding this comment.
The idea for #19387 is that we might be able to push down trivial expressions here, thus avoiding the need for any physical optimizer changes/rules.
Comment on lines
+2166
to
+2170
| LogicalPlan::Filter(filter) => { | ||
| // Split AND predicates into individual expressions | ||
| filters.extend(split_conjunction(&filter.predicate).into_iter().cloned()); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Maybe we can drop this since filters are effectively pushed into TableScan now?
github-actions
bot
added
the
documentation
adriangb
force-pushed
the
move-filters
branch
from
c4b139d to
d0ff08f
Compare
github-actions
bot
removed
the
documentation
adriangb
force-pushed
the
move-filters
branch
from
538fafe to
37d40e8
Compare
adriangb
force-pushed
the
move-filters
branch
from
37d40e8 to
0166985
Compare
Contributor
Author
|
@kosiew would you be open to reviewing this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Closes #19894. I think this will also help with #19387 as well.