refactor: Add Lombok annotations to hudi-utilities (Part 2) #17876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| @Override | ||
| public String toString() { |
Contributor
There was a problem hiding this comment.
Should we leave this as is?
Member
Author
There was a problem hiding this comment.
I'm okay with leaving it as is, any particular reason why?
The generated string feels a little more informative:
public String toString() {
String var10000 = this.name();
return "IncrSourceHelper.MissingCheckpointStrategy." + var10000 + "(description=" + this.getDescription() + ")";
}LMK
Comment on lines
-113
to
-118
| /** | ||
| * Configuration used when generating a schema for a proto class. | ||
| * @param wrappedPrimitivesAsRecords if true, to treat wrapped primitives like record with a single "value" field. If false, treat them as a nullable field | ||
| * @param maxRecursionDepth the number of times to unravel a recursive proto schema before spilling the rest to bytes | ||
| * @param timestampsAsRecords if true convert {@link Timestamp} to a Record with a seconds and nanos field. If false, convert it to a long with the timestamp-mircos logical type. | ||
| */ |
Contributor
There was a problem hiding this comment.
Is there a way to preserve this? Can it be moved to the class javadoc?
Member
Author
There was a problem hiding this comment.
It's actually preserved. Only thing not preserved is:
Configuration used when generating a schema for a proto class.. I'll put this above @AllArgsConstructor.
The individual param descriptions are added as comments above each attribute/fields.
voonhous
force-pushed
the
lombokify-hudi-utilities-p2
branch
from
dc9c749 to
e5e1c4b
Compare
voonhous
force-pushed
the
lombokify-hudi-utilities-p2
branch
from
e5e1c4b to
c18038d
Compare
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the issue this Pull Request addresses
This PR refactors the
hudi-utilitiesmodule to reduce boilerplate code by leveraging Project Lombok annotations. Specifically, it replaces explicitLoggerinstantiation, manual getter/setter methods, and empty constructors with their equivalent Lombok annotations (@Slf4j,@Getter,@Setter,@NoArgsConstructor,@AllArgsConstructor,@Data,@Value,@ToString).This improves code readability and maintainability without altering the runtime logic.
This is part 2 / 3.
Summary and Changelog
This change introduces the Lombok dependency to the
hudi-utilitiesmodule and refactors several classes to utilize Lombok annotations.hudi-utilitiesmodules.Impact
Risk Level
none
(This is a pure refactoring change involving standard library annotations; no business logic was modified.)
Documentation Update
none
Contributor's checklist