Skip to content

Conversation

@the-other-tim-brown
Copy link
Contributor

@the-other-tim-brown the-other-tim-brown commented Jan 16, 2026

Describe the issue this Pull Request addresses

The CompletionTimeQueryViewV2 will load the completion times incrementally and focus on loading the minimal set of files from the archived timeline. The issue is that it will potentially load the same file multiple times since it reads all entries from the file but only processes the instants in the provided range.

The inefficiency is seen when loading the view for instant at time T2 then at time T1. The LSMTimeline is read up to time T1 but only instants up to T2 are processed. The next request for T1 will re-read the file.

Summary and Changelog

  • Update the filtering to only apply at the file level
  • Update the ArchivedTimelineLoader interface to return the earliest instant time processed.
  • Update the cursor to use the returned instant time

Impact

Makes loading the FileSystemView significantly more performant when there are archived instants

Risk Level

Low

Documentation Update

Contributor's checklist

  • Read through contributor's guide
  • Enough context is provided in the sections above
  • Adequate tests were added if applicable

@hudi-bot
Copy link
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@the-other-tim-brown the-other-tim-brown marked this pull request as ready for review January 16, 2026 17:45
Copy link
Contributor

@danny0405 danny0405 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, nice contribution!

@danny0405 danny0405 merged commit 531a48d into apache:master Jan 19, 2026
72 of 76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M PR with lines of changes in (100, 300]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants