-
Notifications
You must be signed in to change notification settings - Fork 679
netutils/netinit: Support the NETINIT_WIFIMAC. #3315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
236d69d to
7cd49c9
Compare
|
@13627105546 Please fix |
netutils/netinit/netinit.c
Outdated
|
|
||
| #if defined(CONFIG_NETINIT_UIDMAC) | ||
| #if defined(CONFIG_NETINIT_WIFIMAC) | ||
| #define BOARDIOC_USER_MAC_WIFI (BOARDIOC_USER + 3) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's define a offical boar ioctl to expose the mac address, @13627105546
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apache/nuttx#18031, I have submitted a commit, which needs to wait for the NuttX commit to be merged first.
7cd49c9 to
25bcf5e
Compare
| static void netinit_set_macaddr(void) | ||
| { | ||
| #if defined(CONFIG_NETINIT_UIDMAC) | ||
| #if defined(CONFIG_NETINIT_WIFIMAC) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if both wifi and eth are available? Having wifi defined will discard mac definition, correct?
Shouldn't we
#if defined(CONFIG_NETINIT_WIFIMAC)
char wifi_mac_str[20];
uint8_t wifi_mac[IFHWADDRLEN];
#endif
#if defined(CONFIG_NETINIT_UIDMAC)
..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have made the revisions. Could you kindly take another look?
25bcf5e to
c710681
Compare
c710681 to
e4972d1
Compare
e4972d1 to
6020df4
Compare
Support getting MAC from boardctl for Wi-Fi. Signed-off-by: liqinhui <[email protected]>
6020df4 to
0029809
Compare
acassis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@13627105546 this is a new Feature, please add a Documentation to it
Note: Please adhere to Contributing Guidelines.
Summary
Impact
Testing