forked from SuperKali/armbian-imager
-
-
Notifications
You must be signed in to change notification settings - Fork 12
Generate simple website with download auto-detection #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
igorpecovnik
wants to merge
3
commits into
main
Choose a base branch
from
test
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Todo: styling
Member
|
I like the idea, yes i think we can restyling it better! |
Member
Author
We can also give this task to someone else. I need to warm up people that will redesign web page. No rush with this. |
Member
It's ok for me :) |
Member
The findBestAsset function was too restrictive, requiring "macos" to be in the filename. This failed to detect files like "Armbian.Imager_1.2.4_aarch64.dmg" that identify as macOS via .dmg extension instead. Updated the logic to recognize macOS files by: - Explicitly checking for .dmg extension - Using a consolidated isMac variable for cleaner code - Also filtering .dmg files from the Linux tab
Member
Author
|
Try now. |
Member
406c789 to
bcbf8c1
Compare
bb9e983 to
a0e7add
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


Imager landing page: https://imager.armbian.com/
Todo: styling