Skip to content

Switch SignalK install to npm#540

Merged
mgrouch merged 1 commit intotrixiefrom
codex/switch-from-pnpm-to-npm-in-install-script
Feb 3, 2026
Merged

Switch SignalK install to npm#540
mgrouch merged 1 commit intotrixiefrom
codex/switch-from-pnpm-to-npm-in-install-script

Conversation

@mgrouch
Copy link

@mgrouch mgrouch commented Feb 3, 2026

Motivation

  • Replace pnpm with regular npm for plugin installation to simplify the install flow and avoid pnpm-specific approval/workarounds.
  • Remove pnpm-related environment setup and runtime patches that are no longer necessary when using npm.

Description

  • Removed pnpm from the global tooling install and kept npm, patch-package, typescript, and node-gyp in the npm install -g step in install-scripts/4-server/04-signalk.sh.
  • Removed PNPM_HOME and PATH modifications and updated the log output to no longer reference pnpm.
  • Switched plugin installation from pnpm install ... (with pnpm approve-builds) to npm install --unsafe-perm --loglevel error --omit=dev ... and removed the pnpm-specific sed patches that switched signalk-server to use pnpm.

Testing

  • No automated tests were run for this change.

Codex Task

@chatgpt-codex-connector
Copy link

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@coderabbitai
Copy link

coderabbitai bot commented Feb 3, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch codex/switch-from-pnpm-to-npm-in-install-script

Important

Action Needed: IP Allowlist Update

If your organization protects your Git platform with IP whitelisting, please add the new CodeRabbit IP address to your allowlist:

  • 136.113.208.247/32 (new)
  • 34.170.211.100/32
  • 35.222.179.152/32

Failure to add the new IP will result in interrupted reviews.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mgrouch mgrouch merged commit 8140c90 into trixie Feb 3, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant