Skip to content

Conversation

@sebhewelt
Copy link
Contributor

πŸš€ Pull Request

πŸ“ Description

Appends the required '/ksiazka' suffix to the Lubimyczytac URL and ensures the href is an empty string if the ID is missing to prevent malformed links.

Fixes #2265

πŸ› οΈ Changes Implemented

πŸ§ͺ Testing Strategy

πŸ“Έ Visual Changes (if applicable)


⚠️ Required Pre-Submission Checklist

Please Read - This Checklist is Mandatory

Important Notice: We've experienced several production bugs recently due to incomplete pre-submission checks. To maintain code quality and prevent issues from reaching production, we're enforcing stricter adherence to this checklist.

All checkboxes below must be completed before requesting review. PRs that haven't completed these requirements will be sent back for completion.

Mandatory Requirements (please check ALL boxes):

  • Code adheres to project style guidelines and conventions
  • Branch synchronized with latest develop branch (please resolve any merge conflicts)
  • 🚨 CRITICAL: Automated unit tests added/updated to cover changes (MANDATORY for ALL Spring Boot backend and Angular frontend changes - this is non-negotiable)
  • 🚨 CRITICAL: All tests pass locally (run ./gradlew test for Spring Boot backend, and ng test for Angular frontend - NO EXCEPTIONS)
  • 🚨 CRITICAL: Manual testing completed in local development environment (verify your changes work AND no existing functionality is broken - test related features thoroughly)
  • Flyway migration versioning follows correct sequence (if database schema was modified)
  • Documentation PR submitted to booklore-docs (required for features or enhancements that introduce user-facing or visual changes)

Why This Matters:

Recent production incidents have been traced back to:

  • Incomplete testing coverage (especially backend)
  • Merge conflicts not resolved before merge
  • Missing documentation for new features

Backend changes without tests will not be accepted. By completing this checklist thoroughly, you're helping maintain the quality and stability of Booklore for all users.

Note to Reviewers: Please verify the checklist is complete before beginning your review. If items are unchecked, kindly ask the contributor to complete them first.


πŸ’¬ Additional Context (optional)

Appends the required '/ksiazka' suffix to the Lubimyczytac URL and ensures
the href is an empty string if the ID is missing to prevent malformed links.
@acx10
Copy link
Collaborator

acx10 commented Jan 30, 2026

@sebhewelt Thanks for the PR! I’m a bit short on time to test this myself. If possible, could you please share a quick video or screenshot showing the updated link behavior? Appreciate it!

@acx10 acx10 added the bug Something isn't working label Jan 30, 2026
@sebhewelt
Copy link
Contributor Author

Hey @acx10 πŸ‘‹πŸ» thank you for all your efforts here, loving the project!

Here's a quick demo showing the fix of the lubimyczytac.pl URLs in 2 places:

lubimyczytac-demo-fix.mov

@sebhewelt sebhewelt marked this pull request as ready for review January 31, 2026 12:26
@acx10
Copy link
Collaborator

acx10 commented Jan 31, 2026

@sebhewelt Looks great!

@acx10 acx10 merged commit 0a7b67b into booklore-app:develop Jan 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Link to lubimyczytac is incomplete

2 participants