fix: semgrep-missing-unlock-before-return #2489
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-before-return-163-ZOt25WBdla fix: semgrep-missing-unlock-before-return
github-actions
bot
added
type/enhancement
Author
|
Hi @jjbustamante, can you please look into it and let me know if any changes are required |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request — Semgrep Rule Fix
Rule ID: missing-unlock-before-return
Rule Message: Missing mutex unlock (c.outputMux variable) before returning from a function. This could result in panics resulting from double lock operations
File Path: /tools/scanResult/unzipped-1969552506/acceptance/invoke/pack.go
Line: 163
Summary
This pull request resolves a concurrency issue detected by Semgrep, where a mutex (
outputMux) was not unlocked before an early return. Failing to unlock a mutex can lead to deadlocks and unpredictable behavior.Change Details
Modified File
acceptance/invoke/pack.goUpdate
c.outputMux.Unlock()immediately before the earlyreturnstatement to ensure the mutex is always released.Rationale
The Semgrep check identified that the function could return without unlocking the mutex, which can result in blocked goroutines and test instability. This PR ensures proper lock management and prevents potential deadlocks.