[wip] feat: Refactor change-tracking logic to db trigger #216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanrudi
changed the title
This was referenced Nov 7, 2025
BobdenOs
reviewed
Dec 19, 2025
| const insertSQL = `INSERT INTO sap_changelog_Changes | ||
| (ID, ATTRIBUTE, VALUECHANGEDFROM, VALUECHANGEDTO, ENTITY, ENTITYKEY, OBJECTID, ROOTENTITY, ROOTENTITYKEY, ROOTOBJECTID, CREATEDAT, CREATEDBY, VALUEDATATYPE, MODIFICATION, TRANSACTIONID) | ||
| VALUES | ||
| (RANDOM_UUID(), '${col.name}', NULL, ${sqlExpr}, ?, ?, ?, ?, ?, ?, CURRENT_TIMESTAMP(), CURRENT_USER(), '${col.type}', 'create', TRANSACTION_ID())`; |
Contributor
There was a problem hiding this comment.
CURRENT_TIMESTAMP and CURRENT_USER are very likely supposed to be $now and $user. For their SQL equivelent it is defined at @sap/cds-compiler/lib/render/utils/common.js.
lib/trigger/hdi.js
Outdated
|
|
||
| function considerLargeString(val) { | ||
| // CASE WHEN LENGTH(:val) > 5000 THEN LEFT(:val, 4997) || '...' ELSE :val END | ||
| return val === 'NULL' ? 'NULL' : `CASE WHEN LENGTH(${val}) > 5000 THEN LEFT(${val}, 4997) || '...' ELSE ${val} END`; |
Contributor
There was a problem hiding this comment.
This could be a re use function if it would have used cqn.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new version of the change-tracking plugin where the creation of changes and changelogs are done by DB trigger instead of event handlers. This allow performance advantages and support for both runtimes.
Before Merge
LargeStringleading to failing insert #173)