[cleanup]: remove deprecated liveness driver and related metrics artifacts#6003
[cleanup]: remove deprecated liveness driver and related metrics artifacts#6003Coderxrohan wants to merge 3 commits intoceph:develfrom
Conversation
Coderxrohan
force-pushed
the
cleanup-liveness-driver
branch
from
e4f0c49 to
aa19fd2
Compare
Madhu-1
left a comment
Madhu-1
left a comment
There was a problem hiding this comment.
@Coderxrohan Thanks for the work, did you get a chance to verify that profing endpoint works if we remove it? what about the code in the liveness.go?
|
This is kind of a breaking change, we need to add it to Pending release notes. cc @Rakshith-R @nixpanic |
Signed-off-by: Rohan Satkar <[email protected]>
Signed-off-by: Rohan Satkar <[email protected]>
Coderxrohan
force-pushed
the
cleanup-liveness-driver
branch
from
1234a6d to
f44ce82
Compare
@Madhu-1, Agree that this is a breaking change, |
|
docs/rbd/deploy.md
Outdated
| | `--pidlimit` | _0_ | Configure the PID limit in cgroups. The container runtime can restrict the number of processes/tasks which can cause problems while provisioning (or deleting) a large number of volumes. A value of `-1` configures the limit to the maximum, `0` does not configure limits at all. | | ||
| | `--metricsport` | `8080` | TCP port for liveness metrics requests | | ||
| | `--metricspath` | `"/metrics"` | Path of prometheus endpoint where metrics will be available | | ||
| | `--polltime` | `"60s"` | Time interval in between each poll | |
There was a problem hiding this comment.
we can remove polltime & timeout from here?
There was a problem hiding this comment.
Sure, this will work. I have removed them. Thanks!
| | `--pluginpath` | "/var/lib/kubelet/plugins/" | The location of cephcsi plugin on host | | ||
| | `--pidlimit` | _0_ | Configure the PID limit in cgroups. The container runtime can restrict the number of processes/tasks which can cause problems while provisioning (or deleting) a large number of volumes. A value of `-1` configures the limit to the maximum, `0` does not configure limits at all. | | ||
| | `--metricsport` | `8080` | TCP port for liveness metrics requests | | ||
| | `--metricspath` | `/metrics` | Path of prometheus endpoint where metrics will be available | |
There was a problem hiding this comment.
Why metricspath is removed here?
There was a problem hiding this comment.
Thanks for pointing this out.
polltime and timeout were tied to the deprecated liveness driver, so they can be removed from docs as well,
I’ll update that.
metricspath was unintentionally dropped in cephfs; I’ll restore it for consistency with RBD.
Signed-off-by: Rohan Satkar <[email protected]>
Coderxrohan
force-pushed
the
cleanup-liveness-driver
branch
from
e646090 to
e2871c4
Compare
|
@iPraveenParihar |
3 participants
Issue:
Ceph-CSI includes a legacy liveness driver and related deployment artifacts (sidecar containers, Services, ServiceMonitors, and documentation) that are no longer needed. Kubernetes now provides native liveness and health probing, making the custom liveness driver redundant.
Fix:
Impact:
Level:
Medium-severity cleanup / technical debt reduction
Fixes: #5599