merge queue: embarking devel (63bdf50) and #5957 together#6019
Closed
mergify[bot] wants to merge 7 commits intodevelfrom
Closed
merge queue: embarking devel (63bdf50) and #5957 together#6019mergify[bot] wants to merge 7 commits intodevelfrom
mergify[bot] wants to merge 7 commits intodevelfrom
Conversation
This patch adds a validator function for volumeID which asserts that the value matches the expected format. Signed-off-by: Niraj Yadav <[email protected]>
This patch modifies RBD controllerserver and nodeserver methods to use `util.ValidateVolumeID`. It is done to ensure the provided VolumeId in the gRPC matches the expected format. Signed-off-by: Niraj Yadav <[email protected]> Reported-by: Shaul Ben Hai <[email protected]>
This patch modifies CephFS controllerserver and nodeserver methods to use `util.ValidateVolumeID`. It is done to ensure the provided VolumeId in the gRPC matches the expected format. Signed-off-by: Niraj Yadav <[email protected]> Reported-by: Shaul Ben Hai <[email protected]>
This patch modifies nvmeof controllerserver and nodeserver methods to use `util.ValidateVolumeID`. It is done to ensure the provided VolumeId in the gRPC matches the expected format. Signed-off-by: Niraj Yadav <[email protected]> Reported-by: Shaul Ben Hai <[email protected]>
This patch modifies `ValidateVolumeID` to include a flag which once set, skips the format enforcement. This is required in case of static volumes where the VolumeID could differ from the expected format. The code elsewhere is modified to consume `VolumeContext` and check if `staticVolume` is set to true. If `VolumeContext` is not present the format enforcement is skipped using the aforementioned flag. Signed-off-by: Niraj Yadav <[email protected]>
This patch modifies nfs controllerserver and nodeserver methods to use `util.ValidateVolumeID`. It is done to ensure the provided VolumeId in the gRPC matches the expected format. Signed-off-by: Niraj Yadav <[email protected]> Reported-by: Shaul Ben Hai <[email protected]>
ceph-csi-bot
added
queued
backport-to-release-v3.16
ok-to-test
Collaborator
|
/test ci/centos/upgrade-tests-cephfs |
Collaborator
|
/test ci/centos/upgrade-tests-rbd |
Collaborator
|
/test ci/centos/k8s-e2e-external-storage/1.34 |
Collaborator
|
/test ci/centos/k8s-e2e-external-storage/1.35 |
Collaborator
|
/test ci/centos/k8s-e2e-external-storage/1.33 |
Collaborator
|
/test ci/centos/mini-e2e-helm/k8s-1.34 |
Collaborator
|
/test ci/centos/mini-e2e-helm/k8s-1.35 |
Collaborator
|
/test ci/centos/mini-e2e-helm/k8s-1.33 |
Collaborator
|
/test ci/centos/mini-e2e/k8s-1.34 |
Collaborator
|
/test ci/centos/mini-e2e/k8s-1.35 |
Collaborator
|
/test ci/centos/mini-e2e/k8s-1.33 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 This pull request has been checked successfully and will be merged soon. 🎉
Branch devel (63bdf50) and #5957 are embarked together for merge.
This pull request has been created by Mergify to speculatively check the mergeability of #5957.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue
defaultfor merge:#approved-reviews-by >= 2[🛡 GitHub branch protection]VolumeIDin incoming gRPC requests #5957#changes-requested-reviews-by = 0[🛡 GitHub branch protection]VolumeIDin incoming gRPC requests #5957base=develstatus-success=codespellstatus-success=go-teststatus-success=golangci-lintstatus-success=lint-extrasstatus-success=mod-checkstatus-success=multi-arch-buildstatus-success=uncommitted-code-checkstatus-success=ci/centos/k8s-e2e-external-storage/1.33status-success=ci/centos/k8s-e2e-external-storage/1.34status-success=ci/centos/k8s-e2e-external-storage/1.35status-success=ci/centos/mini-e2e-helm/k8s-1.33status-success=ci/centos/mini-e2e-helm/k8s-1.34status-success=ci/centos/mini-e2e-helm/k8s-1.35status-success=ci/centos/mini-e2e/k8s-1.33status-success=ci/centos/mini-e2e/k8s-1.34status-success=ci/centos/mini-e2e/k8s-1.35status-success=ci/centos/upgrade-tests-cephfsstatus-success=ci/centos/upgrade-tests-rbdlabel=ci/skip/e2eVolumeIDin incoming gRPC requests #5957base~=^(release-.+)$label=ci/skip/e2eVolumeIDin incoming gRPC requests #5957status-success=ci/centos/k8s-e2e-external-storage/1.32status-success=ci/centos/mini-e2e-helm/k8s-1.32status-success=ci/centos/mini-e2e/k8s-1.32status-success=ci/centos/k8s-e2e-external-storage/1.33status-success=ci/centos/k8s-e2e-external-storage/1.34status-success=ci/centos/mini-e2e-helm/k8s-1.33status-success=ci/centos/mini-e2e-helm/k8s-1.34status-success=ci/centos/mini-e2e/k8s-1.33status-success=ci/centos/mini-e2e/k8s-1.34status-success=ci/centos/upgrade-tests-cephfsstatus-success=ci/centos/upgrade-tests-rbdstatus-success=codespellstatus-success=go-teststatus-success=golangci-lintstatus-success=lint-extrasstatus-success=mod-checkstatus-success=multi-arch-buildstatus-success=uncommitted-code-checkbase=release-v3.15label=ci/skip/e2eVolumeIDin incoming gRPC requests #5957status-success=ci/centos/k8s-e2e-external-storage/1.31status-success=ci/centos/k8s-e2e-external-storage/1.32status-success=ci/centos/mini-e2e-helm/k8s-1.31status-success=ci/centos/mini-e2e-helm/k8s-1.32status-success=ci/centos/mini-e2e/k8s-1.31status-success=ci/centos/mini-e2e/k8s-1.32status-success=ci/centos/k8s-e2e-external-storage/1.33status-success=ci/centos/mini-e2e-helm/k8s-1.33status-success=ci/centos/mini-e2e/k8s-1.33status-success=ci/centos/upgrade-tests-cephfsstatus-success=ci/centos/upgrade-tests-rbdstatus-success=codespellstatus-success=go-teststatus-success=golangci-lintstatus-success=lint-extrasstatus-success=mod-checkstatus-success=multi-arch-buildstatus-success=uncommitted-code-checkbase=ci/centosstatus-success=ci/centos/jjb-validatestatus-success=ci/centos/job-validationRequired conditions to stay in the queue:
#approved-reviews-by >= 2[🛡 GitHub branch protection]VolumeIDin incoming gRPC requests #5957#changes-requested-reviews-by = 0[🛡 GitHub branch protection]VolumeIDin incoming gRPC requests #5957