-
Notifications
You must be signed in to change notification settings - Fork 197
moved check for valid ipv4 as to not accept bogus address when matching /0 range #6015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@cf-bottom Heyo, jenkins please? |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/13314/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-13314/ |
|
Thanks! Please add to the commit message. You can use |
5487343 to
10bca9d
Compare
olehermanse
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SimonThalvorsen The Ticket and Changelog parts Lars mentioned should be a kind of "footer", the commit should still have a good title (first line).
See here for more info and examples;
https://github.com/cfengine/core/blob/master/CONTRIBUTING.md
…hen matching /0 range Ticket: CFE-3081 Changelog: Fixed bug where isipinsubnet() fails to validate bogus IPv4 addresses when checking the 0.0.0.0/0 range
10bca9d to
ffd3ce4
Compare
|
@cf-bottom jenkins, please |
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/13320/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-13320/ |
No description provided.