Kerolasa/init wd #85
Open
Kerolasa/init wd #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sami Kerola <[email protected]>
Reference: https://pkg.go.dev/io/ioutil Signed-off-by: Sami Kerola <[email protected]>
When an initial working directory fails to populate upgrades will fail even when user supplied pid file is defined. This change fixes the issue. Signed-off-by: Sami Kerola <[email protected]>
The build failed with following message.
Run test -z "$(gofmt -l ./ | tee /dev/stderr)"
doc.go
Error: Process completed with exit code 1.F
Signed-off-by: Sami Kerola <[email protected]>
chreo
reviewed
Jan 20, 2026
| dir = initialWD | ||
| wd, err := os.Getwd() | ||
| if err != nil { | ||
| return err |
There was a problem hiding this comment.
Does this need fmt.Errorf(), wrapping the error with some context about the failure point ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DNS-12599: avoid failing upgrade due to initWD being empty
When an initial working directory fails to populate upgrades will fail even
when user supplied pid file is defined. This change fixes the issue.
Signed-off-by: Sami Kerola [email protected]
chore: do not use deprecated ioutls package
Reference: https://pkg.go.dev/io/ioutil
Signed-off-by: Sami Kerola [email protected]
chore: vendor update 2026-01-13
Signed-off-by: Sami Kerola [email protected]