Skip to content

Conversation

@osterman
Copy link
Member

what

  • Create comprehensive PRD for Atmos feature flags system
  • Add 12 milestones to roadmap for Q2-Q3 2026 implementation
  • Document .features context system with deep merge behavior
  • Include profile integration for environment-specific defaults

why

Features provide a clean abstraction for cross-cutting concerns like versioned components (EKS versions), compliance requirements, and deployment strategies. This PRD enables tracking and implementation planning.

references

  • Feature flags enable managing EKS versions, compliance, and deployment strategies declaratively
  • Similar to profiles but target stack/component config rather than CLI behavior
  • Features are mixins with CLI control and built-in discoverability

Create comprehensive PRD for declarative feature flags system. Features are mixins with CLI control, ideal for managing versioned components (EKS versions), compliance requirements, and deployment strategies. Features provide context via .features accessible in templates, supporting deep merge when multiple features are enabled.

Includes profile integration for environment-specific feature defaults and parameterized features for reusable configurations.

Co-Authored-By: Claude Haiku 4.5 <[email protected]>
@osterman osterman requested a review from a team as a code owner January 13, 2026 17:20
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 13, 2026

Caution

Review failed

The head commit changed during the review from 9c613f4 to 2e3970b.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch osterman/feature-flags-prd

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added the size/l Large size PR label Jan 13, 2026
@github-actions
Copy link

github-actions bot commented Jan 13, 2026

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

None

Blue-green deployments select a target (blue OR green), not enable a mode.

Co-Authored-By: Claude Haiku 4.5 <[email protected]>
- Replace --feature/--features-override with single --features flag
- Replace ATMOS_FEATURE/ATMOS_FEATURES_OVERRIDE with single ATMOS_FEATURES
- Both use replacement semantics (explicit control over features)
- Simplify precedence: CLI > env var > stack > profile (4 levels, not 6)
- Update all examples to use nested paths (versions/eks/1.30, compliance/hipaa)
- Remove Open Question #4 about CLI parameter syntax
- Update roadmap milestones to reflect simplified design

Co-Authored-By: Claude Opus 4.5 <[email protected]>
@codecov
Copy link

codecov bot commented Jan 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.15%. Comparing base (b24edb5) to head (2e3970b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1956      +/-   ##
==========================================
+ Coverage   74.13%   74.15%   +0.01%     
==========================================
  Files         772      772              
  Lines       69744    69847     +103     
==========================================
+ Hits        51708    51795      +87     
- Misses      14611    14629      +18     
+ Partials     3425     3423       -2     
Flag Coverage Δ
unittests 74.15% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-release Do not create a new release (wait for additional code changes) size/l Large size PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants