Improve waitUrlEquals error message to include actual error #5383
+10
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavertMik
approved these changes
Jan 15, 2026
DavertMik
requested changes
Jan 15, 2026
Contributor
DavertMik
left a comment
DavertMik
left a comment
There was a problem hiding this comment.
Can you maybe think to rewrite this function completely?
I don't like its code...
Maybe we can make a better version at least for Playwright?
We can use this method https://playwright.dev/docs/api/class-page#page-wait-for-url
https://playwright.dev/docs/api/class-page#page-wait-for-url
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When
waitUrlEqualstimes out but expected URL matches current URL: #5208Solution
Check if URLs match. If yes, show the actual error message