feat(coder/modules/claude-code): add support for aibridge #657
Conversation
|
wip. |
# Conflicts: # registry/coder/modules/claude-code/README.md # registry/coder/modules/claude-code/main.test.ts
| # Add API key only if set | ||
| if [ -n "${CLAUDE_API_KEY:-}" ]; then | ||
| jq --arg apikey "${CLAUDE_API_KEY}" '.primaryApiKey = $apikey' "$claude_config" > "${claude_config}.tmp" && mv "${claude_config}.tmp" "$claude_config" | ||
| fi |
There was a problem hiding this comment.
Do we get any benefit from adding the key to the file? Why not only rely on coder_env and set it as ANTHROPIC_API_KEY or ANTHROPIC_AUTH_TOKEN instead?
There was a problem hiding this comment.
I think it would be best to do this as well. Since this is the best way to ensure its set for claude-code globally in the environment. I moved the model to a coder env in the previous update as well.
There was a problem hiding this comment.
I am a bit confused. Are you in favoir or against of moving this to an ENV variable?
|
@35C4n0r other than what atif mentioned this looks good to me! |
There was a problem hiding this comment.
The coder_ai_task + data.coder_task.me boilerplate appears twice:
- In "Usage with Tasks and Advanced Configuration"
- In "Usage with tasks and AI Bridge"
Suggestion: Consolidate by showing the tasks pattern once, then have AI Bridge examples just show the enable_aibridge = true addition:
### Usage with Tasks
resource "coder_ai_task" "task" {
count = data.coder_workspace.me.start_count
app_id = module.claude-code.task_app_id
}
data "coder_task" "me" {}
module "claude-code" {
source = "registry.coder.com/coder/claude-code/coder"
version = "4.5.0"
agent_id = coder_agent.main.id
workdir = "/home/coder/project"
ai_prompt = data.coder_task.me.prompt
# Optional: route through AI Bridge
# enable_aibridge = true
}Then the AI Bridge section can be simplified to just show standalone usage and reference that tasks work by adding enable_aibridge = true to the above example.
4 participants
Description
Type of Change
Module Information
Path:
registry/coder/modules/claude-codeNew version:
v4.5.0Breaking change: [ ] Yes [ ] No
Testing & Validation
bun test)bun fmt)Related Issues
Closes: #649