fix: include env interpolation in compose includes #848
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When a top-level
includesupplies variables viaenv_file, those variables were not available later when parsingenv_filereferenced by services in the included compose file. Repro:docker compose configfailed with: required variable VAR is missing a value.Fix
Merge variables read from an
include'senv_fileinto the parent environment so they are available when service-levelenv_filefiles are parsed later during project resolution. This is a small, non-invasive change in include.go.Files changed
TestIncludeEnvFileInterpolation(regression test) ✅Tests
TestIncludeEnvFileInterpolationin loader package.go test ./loader -run TestIncludeEnvFileInterpolation -vgo test mahesh.Compatibility & scope
Suggested commit message
Checklist for reviewers
go test mahesh.)Related issue