feat: add dismissable profile completion indicator #5294
+64
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add dismiss button to profile completion card in dropdown menu. When dismissed, both the yellow indicator dot on the profile button and the card are permanently hidden. Uses the action pattern for persistent dismissal tracking. - Add DismissProfileCompletionIndicator action type - Update useProfileCompletionIndicator to check dismissal status - Add showDismiss prop to ProfileCompletion component - Display dismiss button above card content in dropdown only - Remove feature flag and always show indicator for incomplete profiles Co-Authored-By: Claude Haiku 4.5 <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
The ProfileCompletion component now uses useProfileCompletionIndicator which relies on useActions that requires QueryClientProvider. Co-Authored-By: Claude Opus 4.5 <[email protected]>
AmarTrebinjac
changed the title
Remove showDismiss prop and always display the dismiss button regardless of where the component is rendered. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
ENG-291
Preview domain
https://amartrebinjac-eng-291.preview.app.daily.dev