fix: resource cmd with no args panics #63
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logic I wrote to remap some resources to something else (organization membership to organization) for "resource commands" (like get, delete, edit) does not cover the use case where the first argument is omitted so it panics. For example: ``` datumctl get panic ``` With this fix it fallback to what the underline get command does (fails with a nice error)
scotwells
reviewed
Jan 16, 2026
| ) | ||
|
|
||
| func WrapResourceCommand(cmd *cobra.Command) *cobra.Command { | ||
| preRunFunc := func(cmd *cobra.Command, args []string) error { |
Contributor
There was a problem hiding this comment.
Thoughts on just adding in this block?
if len(args) == 0 {
return nil
}That should make this more future proof so we don't make the same mistake if additional mappings are added. Maybe we also consider having a simple map that can be used to map resources.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic I wrote to remap some resources to something else
(organization membership to organization) for "resource commands" (like
get, delete, edit) does not cover the use case where the first argument
is omitted so it panics.
For example:
With this fix it fallback to what the underline get command does (fails
with a nice error)