Fix pinned dotnet-watch TFMs #52517
Merged
Fix pinned dotnet-watch TFMs #52517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Area-AspNetCore
Contributor
|
Thanks for your PR, @@tmat. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the pinned target framework monikers (TFMs) used by dotnet-watch components by centralizing version definitions and correcting the version threshold for selecting hot reload agent assemblies.
Changes:
- Introduces a new
TargetFrameworks.propsfile to centralize pinned TFM definitions for hot reload agent and middleware assemblies - Updates the threshold in
HotReloadAppModel.csfrom .NET 11 to .NET 10 for selecting the appropriate startup hook - Removes the unused
WatchApp60test project
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/BuiltInTools/Watch/TargetFrameworks.props | New file defining centralized, pinned TFM versions for agent and middleware assemblies |
| src/BuiltInTools/Watch/RuntimeDependencies.props | Imports TargetFrameworks.props and replaces hardcoded TFMs with property references |
| src/BuiltInTools/Watch/AppModels/HotReloadAppModel.cs | Changes version threshold from 11 to 10 for selecting net10.0 vs net6.0 startup hook |
| src/BuiltInTools/HotReloadAgent/Microsoft.DotNet.HotReload.Agent.Package.csproj | Replaces hardcoded net6.0 with AgentTargetFrameworkV6 property |
| src/BuiltInTools/HotReloadAgent.Host/Microsoft.DotNet.HotReload.Agent.Host.Package.csproj | Replaces NetCurrent and net6.0 with AgentTargetFrameworkV10/V6 properties |
| src/BuiltInTools/DotNetDeltaApplier/Microsoft.Extensions.DotNetDeltaApplier.csproj | Replaces NetCurrent and net6.0 with AgentTargetFrameworkV10/V6 properties |
| src/BuiltInTools/BrowserRefresh/Microsoft.AspNetCore.Watch.BrowserRefresh.csproj | Replaces hardcoded net6.0 with MiddlewareTargetFrameworkV6 property |
| src/BuiltInTools/Web.Middleware/Microsoft.DotNet.HotReload.Web.Middleware.Package.csproj | Replaces hardcoded net6.0 with MiddlewareTargetFrameworkV6 property |
| test/TestAssets/TestProjects/WatchApp60/WatchApp60.csproj | Removes unused test project file |
| test/TestAssets/TestProjects/WatchApp60/Program.cs | Removes unused test project file |
This was referenced Jan 16, 2026
3 tasks
MichaelSimons
approved these changes
Jan 21, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: enable tests and update tests to validate 6.0 and 10.0 apps