Fixed: Memory view not supporting 64-bit address while using GnuMcuLaunch

[pnipin]

Fix for: #645

CDT have added support for 64-bit memory addresses long before. Code changes for the support are in the class GdbMemoryBlockRetrieval which inherits from DsfMemoryBlockRetrieval. Embedded CDT launches are using GnuMcuLaunch class (Embedded CDT launcher, used to initialize the memory block retrieval used by the Peripherals view). This launcher uses PeripheralMemoryBlockRetrieval which directly inherits from DsfMemoryBlockRetrieval and misses the 64-bit support in GdbMemoryBlockRetrieval class. If parent class of PeripheralMemoryBlockRetrieval is changed to GdbMemoryBlockRetrieval memory view correctly displays the address contents.

[jonahgraham]

On code inspection this looks right to me.

[ilg-ul]

Is the GdbMemoryBlockRetrieval class available in the older Eclipse that these plugins are based on?

[pnipin]

Is the GdbMemoryBlockRetrieval class available in the older Eclipse that these plugins are based on?

Based on my understanding, GdbMemoryBlockRetrieval is not available in the older Eclipse/CDT versions that the Embedded CDT plug-ins were based on.
Please see the commit history of this class below:
https://github.com/eclipse-cdt/cdt/commits/main/dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/internal/memory/GdbMemoryBlockRetrieval.java

[ilg-ul]

There is a plan to align the plug-ins with a more recent Eclipse version, but I'm not sure how long it'll take.

Please leave this PR open, we'll consider it when ready.

[pnipin]

There is a plan to align the plug-ins with a more recent Eclipse version, but I'm not sure how long it'll take.

Please leave this PR open, we'll consider it when ready.

Ok, Thanks